Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132967 / 25.04 / Trusted Store option not present on CSR creation but is on edit #11197

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

AlexKarpov98
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 commented Dec 17, 2024

Testing: see ticket.

I talked with Waqar, he told me that we should remove Add to Trusted Store for CSR in edit form and not add it for creation form.
Screenshot 2024-12-17 at 13 33 00

@AlexKarpov98 AlexKarpov98 self-assigned this Dec 17, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner December 17, 2024 11:32
@AlexKarpov98 AlexKarpov98 requested review from denysbutenko and removed request for a team December 17, 2024 11:32
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.85%. Comparing base (82c39de) to head (8a00433).
Report is 9 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ash/certificate-edit/certificate-edit.component.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11197      +/-   ##
==========================================
+ Coverage   82.70%   82.85%   +0.14%     
==========================================
  Files        1653     1652       -1     
  Lines       58341    58502     +161     
  Branches     6011     6017       +6     
==========================================
+ Hits        48252    48469     +217     
+ Misses      10089    10033      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bugclerk bugclerk changed the title NAS-132967: Trusted Store option not present on CSR creation but is on edit NAS-132967 / 25.04 / Trusted Store option not present on CSR creation but is on edit Dec 17, 2024
@bugclerk
Copy link
Contributor

@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants