Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132807 / 25.04 / OAuth support for Microsoft Outlook Mail #11206

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Changes:
Added Outlook Send Mail Method for Email.

Testing:
See ticket.

Note - https://ixsystems.atlassian.net/browse/NAS-133131 this ticket is blocked until this PR is merged.
So Send Test Email is not working for Outlook now.

Result:
NAS-132807-1
NAS-132807-2

Downstream

Affects Reasoning
Documentation New OAuth Send Mail Method

@AlexKarpov98 AlexKarpov98 self-assigned this Dec 19, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner December 19, 2024 12:52
@AlexKarpov98 AlexKarpov98 requested review from denysbutenko and removed request for a team December 19, 2024 12:52
@bugclerk bugclerk changed the title NAS-132807: OAuth support for Microsoft Outlook Mail NAS-132807 / 25.04 / OAuth support for Microsoft Outlook Mail Dec 19, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 91.52542% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.47%. Comparing base (4b3fe41) to head (3f4ef8d).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...-settings/email/email-form/email-form.component.ts 85.18% 4 Missing ⚠️
...les/buttons/oauth-button/oauth-button.component.ts 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11206      +/-   ##
==========================================
- Coverage   82.47%   82.47%   -0.01%     
==========================================
  Files        1655     1656       +1     
  Lines       58741    58782      +41     
  Branches     6052     6066      +14     
==========================================
+ Hits        48449    48482      +33     
- Misses      10292    10300       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@AlexKarpov98 AlexKarpov98 merged commit a7794a4 into master Dec 20, 2024
11 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-132807-upd branch December 20, 2024 10:28
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants