Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/autocomplete with metadatawidget #177

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jusa3
Copy link
Collaborator

@jusa3 jusa3 commented Nov 29, 2024

  1. AutocompleteWidget: The hover information of the option doesn't have any design. Add the MetadataWidget for additional and styled information. Doesn't include entity source or source URL yet (should we add this information to the MetadataWidget?). Unstyled hover information still present - should be removed after adding the source information to the MetadataWidget - do not merge this PR before.

Caveat: Not accessible - no links can be clicked and only one tab can be displayed.

Solves #127

image

  1. MetadataWidget: Data not available will result in a blank. Use conditionals to avoid spaces.

Before:
image

After:
image

Solves #176

The hover information of the option doesn't have any design. Add the MetadataWidget for additional and styled information. Doesn't include entity source or source URL yet.

Solves #127
Data not available results in empty space. Add conditionals to avoid blanks.

Solves #176
@Pooya-Oladazimi
Copy link
Collaborator

@jusa3

Nice idea! I just noticed two points:

1- The hover menu should be removed now that we have this in my opinion:
Screenshot from 2024-11-29 14-53-10

2- There is a loading symbol that appears in a small box next to the autocomplete when one hovers over the result. It happens very fast which makes it hard to take a screenshot.

@jusa3
Copy link
Collaborator Author

jusa3 commented Nov 29, 2024

I can remove the old hover menu when we decide what we do with the source and source URL so that no feature gets lost.

It's the loading spinner of the MetadataWidget. The default position of the tooltip is "top" so it first appears on top with the loading spinner and when the data loads and the data is too large for the top position it gets displayed at the bottom. I'm afraid we can't change this behaviour.

@jusa3
Copy link
Collaborator Author

jusa3 commented Dec 13, 2024

First answer this question: #183
and have a look into accessibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants