Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change rotate props #39

Merged
merged 8 commits into from
Jul 27, 2024
Merged

Change rotate props #39

merged 8 commits into from
Jul 27, 2024

Conversation

Slaviiiii
Copy link
Contributor

No description provided.

@Slaviiiii Slaviiiii requested a review from seveibar July 26, 2024 08:25
seveibar
seveibar requested changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed "generous acceptance" which means accepting both values, look at Translate

@Slaviiiii
Copy link
Contributor Author

Slaviiiii commented Jul 26, 2024 •
edited
Loading

I do not think we are using rotation anywhere, right?
I currently am using it for another issue, but I could change the property from angles with the package update, because there aren't any other repos using it.

@seveibar
Copy link
Contributor

@Slaviiiii we should accept both rotation and angles in the <Rotate /> component

@Slaviiiii Slaviiiii requested a review from seveibar July 27, 2024 07:33
@Slaviiiii Slaviiiii merged commit f7b5e90 into main Jul 27, 2024
4 checks passed
@Slaviiiii Slaviiiii deleted the change-rotate-props branch July 27, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seveibar seveibar seveibar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Slaviiiii @seveibar @tscircuitbot