apply bts suggestion

vyper/semantics/analysis/utils.py

@@ -648,9 +648,6 @@ def check_modifiability(node: vy_ast.VyperNode, modifiability: Modifiability) ->
         call_type = get_exact_type_from_node(node.func)
 
         # structs and interfaces
-        if isinstance(call_type, TYPE_T):
-            call_type = call_type.typedef
-
         if hasattr(call_type, "check_modifiability_for_call"):
             return call_type.check_modifiability_for_call(node, modifiability)
 

vyper/semantics/types/base.py

@@ -334,6 +334,11 @@ def __init__(self, typedef):
     def __repr__(self):
         return f"type({self.typedef})"
 
+    def check_modifiability_for_call(self, node, modifiability):
+        if hasattr(self.typedef, "_ctor_modifiability_for_call"):
+            return self.typedef._ctor_modifiability_for_call(node, modifiability)
+        raise StructureException("Value is not callable", node)
+
     # dispatch into ctor if it's called
     def fetch_call_return(self, node):
         if hasattr(self.typedef, "_ctor_call_return"):

vyper/semantics/types/module.py

@@ -84,7 +84,7 @@ def _ctor_arg_types(self, node):
     def _ctor_kwarg_types(self, node):
         return {}
 
-    def check_modifiability_for_call(self, node: vy_ast.Call, modifiability: Modifiability) -> bool:
+    def _ctor_modifiability_for_call(self, node: vy_ast.Call, modifiability: Modifiability) -> bool:
         return check_modifiability(node.args[0], modifiability)
 
     # TODO x.validate_implements(other)

vyper/semantics/types/user.py

@@ -421,5 +421,5 @@ def _ctor_call_return(self, node: vy_ast.Call) -> "StructT":
 
         return self
 
-    def check_modifiability_for_call(self, node: vy_ast.Call, modifiability: Modifiability) -> bool:
+    def _ctor_modifiability_for_call(self, node: vy_ast.Call, modifiability: Modifiability) -> bool:
         return all(check_modifiability(v, modifiability) for v in node.args[0].values)