fix constants dict persistence bug

tserg · Oct 29, 2023 · 65ab902 · 65ab902
1 parent 3e40c38
commit 65ab902
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/vyper/semantics/analysis/module.py b/vyper/semantics/analysis/module.py
@@ -71,9 +71,11 @@ def _add_constants_to_namespace(module_nodes: list[vy_ast.VyperNode], ns: Namesp
                 continue
 
             val = prefold(c.value)
-            ns.add_constant(name, val)
 
+            # note that if a constant is redefined, its value will be overwritten,
+            # but it is okay because the syntax error is handled downstream
             if val is not None:
+                ns.add_constant(name, val)
                 derived_nodes += 1
                 const_var_decls.remove(c)
 

diff --git a/vyper/semantics/namespace.py b/vyper/semantics/namespace.py
@@ -77,6 +77,8 @@ def enter_scope(self):
         if len(self._scopes) == 1:
             # add mutable vars (`self`) to the initial scope
             self.update(environment.get_mutable_vars())
+            # reset constants
+            self._constants = {}
 
         return self