FirebaseUIを使ってログイン周りを作成 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsubasa1122
commented
Apr 23, 2022
Comment on lines
+19
to
+20
| "react": "17.0.2", | ||
| "react-dom": "17.0.2", |
There was a problem hiding this comment.
📝 react18にするとfirebaseuiでエラーになるため、バージョンを下げることにした
sushidesu
approved these changes
May 7, 2022
Comment on lines
+7
to
+13
| export type AuthState = { | ||
| isSignedIn: boolean; | ||
| isLoading: boolean; | ||
| userId: string | undefined; | ||
| userName: string | undefined; | ||
| idToken: string | undefined; | ||
| }; |
There was a problem hiding this comment.
こういう書き方もあるかな〜と思いました！ 🙌
type AuthState = {
type: "signedIn"
userId: string
userName: string
idToken: string
} | {
type: "loading"
} | {
type: "notSignedIn"
}type: "signedIn" のときだけ userId , userName , idToken があると推論されるので、使う側が本来必要のないundefinedのチェックをしなくて良くなる という利点があります！
フラグが複数あると複雑なので ステート で表現したい、というのもあります 👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.