Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Scala 2.13 support #681

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Conversation

plokhotnyuk
Copy link

No description provided.

benblack86 and others added 4 commits January 24, 2018 11:16
* Replace nscala-time with java.time in Cookie class

Before:
  Used nscala-time library to parse expiration date in Cookie class/object.

After:
  Use java.time utilities to parse expiration date.

* Remove nscala-time library from build.sbt

* 0.12.0-SNAPSHOT

* memcache: implement CAS and GETS (tumblr#673)

* memcache implement CAS and GETS

* rename vals/methods; drop compressor from method signature

* rename val; move logic to private function; move docs around

* expand option get

* update to more-idiomatic way to use option

* patch version instead of minor
# Conflicts:
#	version.sbt
@codecov-io
Copy link

codecov-io commented Jun 22, 2019

Codecov Report

Merging #681 into develop will decrease coverage by 1.3%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #681      +/-   ##
===========================================
- Coverage    85.67%   84.37%   -1.31%     
===========================================
  Files          105      111       +6     
  Lines         4525     4589      +64     
  Branches       408      276     -132     
===========================================
- Hits          3877     3872       -5     
- Misses         648      717      +69
Impacted Files Coverage Δ
...rc/main/scala/colossus/service/ServiceServer.scala 92.38% <0%> (-1.91%) ⬇️
...sus/src/main/scala/colossus/service/Callback.scala 87.59% <0%> (-1.56%) ⬇️
.../scala/colossus/metrics/collectors/Histogram.scala 90.57% <0%> (-0.73%) ⬇️
...ain/scala/colossus.examples/WebsocketExample.scala 0% <0%> (ø)
...c/main/scala/colossus.examples/KeyValExample.scala 0% <0%> (ø)
...scala/colossus.examples/StreamServiceExample.scala 0% <0%> (ø)
...ain/scala/colossus.examples/BenchmarkExample.scala 0% <0%> (ø)
...amples/src/main/scala/colossus.examples/Main.scala 0% <0%> (ø)
...src/main/scala/colossus.examples/HttpExample.scala 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af0e5c1...a396818. Read the comment docs.

- update patch versions for Scala
- update Sbt plugins
- simplify aggregation of coverage data on TravisCI, see https://github.com/scoverage/sbt-scoverage#notes-on-upgrading-to-version-160
- add JVM options for stable Sbt builds without OOM errors
- clean up of build configuration from Scala 2.10 waste
@plokhotnyuk plokhotnyuk changed the title Merge missing changes from the master to the develop branch Adding Scala 2.13 support Jun 22, 2019
- update Sbt version to the latest stable release
- fix circular dependency between ColossusProject, ColossusTestProject, and ColossusTestKitProject
@simpadjo
Copy link

For those who want to run colossus on scala-2.13, I finalized PR by @plokhotnyuk in my repo:
https://github.com/simpadjo/colossus .
I also published the packages (snapshots for now) but apparently they are not usable from build tools w/o a token due to github quirks.

p8 added a commit to p8/FrameworkBenchmarks that referenced this pull request Jun 8, 2024
Colossus hasn't been updated for 6 years.
A pull request to make it run on Scala 12.3 has been open for 5 years:
tumblr/colossus#681

Scala 12.2 is end-of-life: https://endoflife.date/scala
NateBrady23 pushed a commit to TechEmpower/FrameworkBenchmarks that referenced this pull request Jun 11, 2024
Colossus hasn't been updated for 6 years.
A pull request to make it run on Scala 12.3 has been open for 5 years:
tumblr/colossus#681

Scala 12.2 is end-of-life: https://endoflife.date/scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants