Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Joe King / Bryan Flanagan Pair Project PR #204

Open
wants to merge 90 commits into
base: main
Choose a base branch
from
Open

Joe King / Bryan Flanagan Pair Project PR #204

wants to merge 90 commits into from

Conversation

bflanagan138
Copy link

Project Submission

bflanagan138 and others added 30 commits January 30, 2023 15:56
@bflanagan138
Create pull_request_template.md
1f5d653 
Created PR template - Created via zoom with both JK & BF
@this-is-joeking
Merge pull request #1 from bflanagan138/bflanagan138-patch-1
33894fd 
Create pull_request_template.md
@bflanagan138
feat: Create migrations:
bb7aca1
@bflanagan138
refactor: Try to change name for genres_movies, didn't work
23dc481
@this-is-joeking
Merge pull request #14 from bflanagan138/bf_migrations
7ad0fd7 
Bf migrations
@this-is-joeking
Refactor: Remove tables from db that will come from TMDB API
a6ee4cb
@bflanagan138
Merge pull request #16 from bflanagan138/jk_migrations
75b74c1 
Refactor: Remove tables from db that will come from TMDB API
@this-is-joeking
feat: Add landing page with button to create a new user
7afe57c
@this-is-joeking
Add coverage directory to .gitignore
400d1d0
@this-is-joeking
feat: Add model associations/validations and associated tests
1cf688d
@this-is-joeking
refactor: Adjusted column names for database to align with best pract…
3e212db 
…ices
@this-is-joeking
feat: Complete landing page
3eb2c0f
@this-is-joeking
refactor: Add styling to center content and add heading to all pages
6d0229e
@bflanagan138
Merge pull request #17 from bflanagan138/jk_landing_page
3563fa4 
Jk landing page
@bflanagan138
feat: Create user registration page with tests
9d92045
@bflanagan138
refactor: Add format cues to users new view
135fb95
@bflanagan138
feat: Create user show page
6c118b2
@bflanagan138
refactor: Update test to check sad path
84e61e2
@bflanagan138
refactor: update welcome index view page with correct path
9f7f47a
@this-is-joeking
Merge pull request #18 from bflanagan138/bf_user_registration_page
5402906 
Bf user registration page
@this-is-joeking
feat: Add content to user dashboard and routes for discover
d70cc35
@this-is-joeking
feat: Add user model method to find viewing party user given the view…
3762c80 
…ing party
@this-is-joeking
feat: Add button to discover movies and basic list of viewing parties
2caec86
@bflanagan138
Merge pull request #21 from bflanagan138/jk_user_dashboard
49aca98 
Jk user dashboard
@bflanagan138
refactor: Format user show page to add border around viewing parties …
d402c95 
…to match wireframe example
@this-is-joeking
Merge pull request #22 from bflanagan138/bf_format_user_show
33fa054 
refactor: Format user show page to add border around viewing parties …
@bflanagan138
feat: create user discover movies page with tests
3a51b65
@bflanagan138
feat: add Find Top Rated Movies button to discover index page, incorr…
5b5903f 
…ect path
@this-is-joeking
Merge pull request #23 from bflanagan138/bf_dashboard_discover_movies
a053ff2 
Bf dashboard discover movies
@this-is-joeking
refactor: Discover Movies page to include button to find top rated mo…
1d17b32 
…vies with working path and search field for finding movies by keyword
this-is-joeking and others added 30 commits February 2, 2023 15:23
@this-is-joeking
test: Add tests for all MovieFacade methods
7665a52
@this-is-joeking
linting: ran rubocops linters
4aceb14
@this-is-joeking
feat: Add initial form for creating viewing_party
3bad24c
@this-is-joeking
feat: Add option to invite users to new viewing party form
cbc7aae
@this-is-joeking
feat: Create #name_and_email for users for proper display in view
22b5208
@this-is-joeking
feat: Complete the new viewing party form
174947c
@bflanagan138
Merge pull request #29 from bflanagan138/jk_facade_tests
fcdfc1f 
Jk facade tests
@bflanagan138
feat: Add movie poster and link to movie page to viewing parties
52196b8
@bflanagan138
feat: Add user guests to dashboard viewing party tiles
4e63045
@this-is-joeking
Merge pull request #30 from bflanagan138/bf_dashboard_viewing_parties
5e7d0ed 
Bf dashboard viewing parties
@this-is-joeking
feat: Created #all_other_users in user class to move this data logic …
49e9d1c 
…out of vp controller
@this-is-joeking
refactor: Added additional tests and moved creation of vp-users to ha…
7a41ad3 
…ppen alongside creation of viewing party
@bflanagan138
Merge pull request #31 from bflanagan138/jk_refactory
12b670c 
Jk refactory
@this-is-joeking
test: Add sad path test for new viewing party page
b58aaa2
@bflanagan138
refactor/test: create poros test for runtime_calc
eb91d7c
@bflanagan138
refactor/feat: Add runtime_calc movie method
cb83c00
@bflanagan138
refactor: Make movie_runtime variable in runtime_calc method
0726f00
@bflanagan138
refactor: Refactor runtime_calc method
3cc6235
@this-is-joeking
style: Add home icon next to link, and change banner font to helvetica
eec7802
@bflanagan138
refactor: Remove save and open page
701ff4b
@this-is-joeking
Merge pull request #33 from bflanagan138/bf_runtime_refactor
4af3467 
Bf runtime refactor
@bflanagan138
Merge pull request #34 from bflanagan138/jk_final_touches
83efee0 
Jk final touches
@this-is-joeking
feat: Add bootstrap gem
1f3330d
@bflanagan138
Merge pull request #35 from bflanagan138/jk_add_bootstrap
b0ae698 
feat: Add bootstrap gem
@bflanagan138
feat: Populate seed file
4760f33
@this-is-joeking
Merge pull request #36 from bflanagan138/bf_create_seeds
27b1972 
feat: Populate seed file
@bflanagan138
refactor: Format viewing party page to list invitees on separate lines
fa9d1a2
@this-is-joeking
Merge pull request #37 from bflanagan138/bf_vp_checkbox
779c65a 
refactor: Format viewing party page to list invitees on separate lines
@this-is-joeking
refactor: Rubocop linting and style corrections
7f9ef64
@bflanagan138
Merge pull request #38 from bflanagan138/jk_rubocop_linting
ea1dc8e 
refactor: Rubocop linting and style corrections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bflanagan138 @this-is-joeking