Add metadataForPartialUploads option to set metadata for partial uploads only
#703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acconut
approved these changes
Sep 9, 2024
|
I'm deeply sorry for not reviewing this earlier! I just had a look at it and polished the implementation, tests and docs. Thank you for working on this PR! |
Acconut
changed the title
metadataForPartialUploads option to set metadata for partial uploads only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative option to this PR which proposes having the option to retain metadata on partial upload requests. Instead of maintaining the metadata from the original request, this PR adds the option for
partialMetadata, which would allow folks to set metadata only for partial requests. This could be the same or different from the original metadata, which allows for more flexibility.