include filtered notifications in the notification tab

[connyduck]

This is a quick workaround to have Tusky behave the same on Mastodon 4.2 and 4.3 instances: All notifications are shown. This should prevent confusion for users that are using mostly Tusky.

Note, I'm also working on full support for filtered notifications, but that will still take a while.

[mcclure]

Conny, I think this is possibly bad, because I think this is going to include "limited user" notifications which would not have been shown in 4.2 (e.g., users that your instance moderators believe may be bad actors).

I don't remember if we discussed this— would it be a large block of work to have just a preference control for which notifications are shown, with no way to see the filtered notifications within Tusky? (Possibly the "filtered notifications" preference pane could have a small noninteractive box at the bottom, explaining filtered notifications will be visible on the website but not currently Tusky.) It seems like the filtered notification display is the hard part, not viewing/setting the preference.

EDIT: Alternately, maybe just a checkbox for "show filtered notifications" would make sense, but that sounds like work that would have to be ripped out later when we move forward to the "real" filtered notifications UI?

[connyduck]

As far as I understand, notifications filtered by server admins will just never be returned, no matter what include_filtered is set to. @ClearlyClaire can you confirm that?

[mcclure]

Hm, I'm looking in the docs and… "include_filtered" isn't in them? :| https://www.google.com/search?q=site%3Adocs.joinmastodon.org+%22include_filtered%22

[ClearlyClaire]

Notifications from limited accounts are created as filtered according to the user's notifications policy, which by default puts those in filtered notifications, and do not drop them (contrary to pre-4.3.0).

[connyduck]

Hm, I'm looking in the docs and… "include_filtered" isn't in them? :| https://www.google.com/search?q=site%3Adocs.joinmastodon.org+%22include_filtered%22

yes those docs are always behind releases unfortunately

Notifications from limited accounts are created as filtered according to the user's notifications policy, which by default puts those in filtered notifications, and do not drop them (contrary to pre-4.3.0).

Thanks for clarifying!
That means I'll close this and speed up the full implementation, ok @mcclure?

[mcclure]

@ClearlyClaire , thanks!

@connyduck , if you feel confident we've reproduced 4.2.x behavior, then my objection is dropped.

But personally I am still confused, I'm sorry :(

Here is my understanding:

• For each of the five notification-filter categories, the user may set "ACCEPT", "FILTER", or "IGNORE".
• If the notification-filter category applies, and the user has set the category to FILTER, the notification gets marked "FILTERED".
• Per Claire's comment above, the default notification-filter settings are ACCEPT for the basic four categories, and FILTER for "Moderated Accounts".
• If we send includeFiltered = true (this patch), then FILTERED notifications are shown in Tusky.

So consider two hypothetical users, and how this patch would affect them.

• User A has not engaged with the notification filter feature. They have the default, which is ACCEPT/ACCEPT/ACCEPT/ACCEPT/FILTER. If we do nothing, the 4.2.x behavior is reproduced (moderated accounts are hidden from the UI; everything else is shown). If we ship this patch, the 4.2.x behavior changes: Moderated accounts, which as Claire says above were previously "dropped", are now shown.
• User B has made full use of the notification filter feature. They have set FILTER for one of the basic four categories. If we do nothing, the 4.2.x behavior changes (posts they previously would have seen are now fully hidden). If we include this patch, it acts like 4.2.x and all these posts are shown (although also they will see "moderated account" posts; but this user knows how notification filters work, so if they don't like seeing moderated posts, they can set moderated accounts to HIDE and reproduce 4.2.x in Tusky).

Am I missing something?

[ClearlyClaire]

The defaults are the following: everything is ACCEPTed except for unsolicited DMs and limited accounts which get FILTERed, so I'm afraid there is no way to recover exactly the same default behavior as before.

I think the safest option is to not use include_filtered, but this is still not ideal.

Also note that what you call “HIDE” will stop the notifications from being created at all, so it's a destructive option and should not be selected lightly (the web UI has a confirmation modal for this).

I guess one possibility is to have some indicator that there are filtered notifications even if Tusky can't show them right away.

[mcclure]

Oh. I'd be very frustrated if Tusky were hiding unsolicited DMs. Then I guess I drop my objections to the patch :( :(