fix(model): Deserialize unavailable guilds in GUILD_CREATE. #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-cache
Erk-
force-pushed
the
erk/model/fix-unavailible-guilds-in-guild-create
branch
2 times, most recently
from
aac819b
to
48b1f66
Compare
laralove143
requested changes
Apr 1, 2024
vilgotf
requested changes
Apr 1, 2024
vilgotf
approved these changes
Apr 1, 2024
Gelbpunkt
requested changes
Apr 6, 2024
This changes GuildCreate from being a tuple struct to being a enum that can either be available or unavailable, and containing either a full Guild or a UnavailableGuild.
Erk-
force-pushed
the
erk/model/fix-unavailible-guilds-in-guild-create
branch
from
a5c2202
to
26e14fa
Compare
|
@Gelbpunkt Added a test now, which also made a small bug show up. |
Gelbpunkt
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
GuildCreatefrom being a tuple struct to being a enum that can either be available or unavailable, and containing either a fullGuildor aUnavailableGuild.