fix: correctly encode and decode base64 on frontend

twirapp · Sep 18, 2023 · 231af70 · 231af70
1 parent cde34d0
commit 231af70
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/frontend/dashboard/src/api/registry/overlays.ts b/frontend/dashboard/src/api/registry/overlays.ts
@@ -4,7 +4,7 @@ import { protectedApiClient } from '@/api/twirp';
 
 function b64EncodeUnicode(str: string) {
 	return btoa(
-		encodeURIComponent(str).replace(/%([0-9A-F]{2})/g, function toSolidBytes(match, p1) {
+		encodeURIComponent(str).replace(/%([0-9A-F]{2})/g, function toSolidBytes(_, p1) {
 			return String.fromCharCode(parseInt('0x' + p1));
 		}),
 	);

diff --git a/frontend/overlays/src/pages/overlaysRegistry.tsx b/frontend/overlays/src/pages/overlaysRegistry.tsx
@@ -159,13 +159,13 @@ export const OverlaysRegistry: React.FC = () => {
 };
 
 
-function b64EncodeUnicode(str: string) {
-	return btoa(
-		encodeURIComponent(str).replace(/%([0-9A-F]{2})/g, function toSolidBytes(match, p1) {
-			return String.fromCharCode(parseInt('0x' + p1));
-		}),
-	);
-}
+// function b64EncodeUnicode(str: string) {
+// 	return btoa(
+// 		encodeURIComponent(str).replace(/%([0-9A-F]{2})/g, function toSolidBytes(_, p1) {
+// 			return String.fromCharCode(parseInt('0x' + p1));
+// 		}),
+// 	);
+// }
 
 function b64DecodeUnicode(str: string) {
 	return decodeURIComponent(