Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exclude field to MultipleEmitters rule. #122

Closed
wants to merge 1 commit into from
Closed

Add exclude field to MultipleEmitters rule. #122

wants to merge 1 commit into from

Conversation

MaximSysoev
Copy link

@MaximSysoev MaximSysoev commented Aug 23, 2023

Hi! Please consider the possibility of adding a field exclude to the MultipleEmitter rule.
I ran into a situation when I have composable function which is always called inside Column, but it is not ColumnScope extension. Like this:

abstract class Screen {
  @Composable
  internal fun Content() {
    // Some logic
    Column(...) {
      Ui()
    }
  }

  @Composable
  abscract fun Ui()
}

I would not like to change it to ColumnScope.Ui() and fix it throughout the project.
It would be nice to just exclude Ui method from rule checking.
Maybe there are some other cases. Anyway it seems pretty flexible.

What do you think about it?

@github-actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@MaximSysoev
Copy link
Author

@mrmans0n Hi! Could you help? Am I doing something wrong? CLA Assistant shows the error, but I have signed SLA.

@kenyee
Copy link
Contributor

kenyee commented Aug 24, 2023

The rules have been moved here: https://github.com/mrmans0n/compose-rules
Because Twitter locked contributors out of this for a while...

@MaximSysoev MaximSysoev closed this by deleting the head repository Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants