Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create_missing_column_families option #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

create_missing_column_families option #44

wants to merge 1 commit into from

Conversation

nitoqq
Copy link

@nitoqq nitoqq commented Feb 27, 2019

Added descriptor for create_missing_column_families db option

@nitoqq
Copy link
Author

nitoqq commented Mar 4, 2019

Hi, what do you think of this PR?

@kataev
Copy link

kataev commented Jun 21, 2019

🐥🐥🐥

@nitoqq nitoqq force-pushed the add-create-missing-column-families-option branch from f9225d3 to ea96bc7 Compare December 10, 2020 12:12
iFA88
iFA88 suggested changes Mar 9, 2021
View reviewed changes
Copy link

@iFA88 iFA88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need declare this also in options.pxd:

    cdef cppclass DBOptions:
        ...
        cpp_bool create_missing_column_families
        ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iFA88 iFA88 iFA88 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nitoqq @kataev @iFA88 @berdoc