This repository has been archived by the owner on Dec 19, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 53
Added Docker Image worflow and update other workflow #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tycrek
suggested changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one thing to change (see review comments)
LGTM ! |
tycrek
approved these changes
Oct 12, 2023
All looks good! Just going to set up Secrets stuff prior to merge |
tycrek
suggested changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny thing
tycrek
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Enviroment
Description
Added Github workflow to build a Docker Image and automatically push it on Docker Hub
Upgraded the Github action version and in prevision make everything working for the new LTS of NodeJS 20
The Github workflow ASS CI build and test the build ASS then makes a Docker Image of it, and after this push it to Docker Hub, when all of the previous stuff is done, it can send Discord notification everything is ready or not.
This would help a lot of people on deploying ASS on Portainer instance or just with Docker Compose, automated everything and maybe if you want it, you can add cypress or eslint or both to the repository so I can make a workflow for testing code.