Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Added Docker Image worflow and update other workflow #234

Merged
merged 6 commits into from
Oct 13, 2023

Conversation

Gauvino
Copy link
Contributor

@Gauvino Gauvino commented Oct 9, 2023

Checklist

  • I have read the Contributing Guidelines
  • I acknowledge that any submitted code will be licensed under the ISC License
  • I confirm that submitted code is my own work
  • I have tested the code, and confirm that it works

Enviroment

  • Operating System: null
  • Node version: 20.8.0
  • npm version: 10.2.0

Description

Added Github workflow to build a Docker Image and automatically push it on Docker Hub
Upgraded the Github action version and in prevision make everything working for the new LTS of NodeJS 20

The Github workflow ASS CI build and test the build ASS then makes a Docker Image of it, and after this push it to Docker Hub, when all of the previous stuff is done, it can send Discord notification everything is ready or not.

This would help a lot of people on deploying ASS on Portainer instance or just with Docker Compose, automated everything and maybe if you want it, you can add cypress or eslint or both to the repository so I can make a workflow for testing code.

Copy link
Owner

@tycrek tycrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one thing to change (see review comments)

.github/workflows/ts-build.yml Outdated Show resolved Hide resolved
.github/workflows/docker-build Outdated Show resolved Hide resolved
.github/workflows/docker-build Outdated Show resolved Hide resolved
.github/workflows/codeql-analysis.yml Show resolved Hide resolved
@Gauvino
Copy link
Contributor Author

Gauvino commented Oct 12, 2023

LGTM !

@tycrek
Copy link
Owner

tycrek commented Oct 12, 2023

All looks good! Just going to set up Secrets stuff prior to merge

@tycrek tycrek added the enhancement New feature or request label Oct 12, 2023
Copy link
Owner

@tycrek tycrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny thing

.github/workflows/docker-build.yml Outdated Show resolved Hide resolved
Copy link
Owner

@tycrek tycrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@tycrek tycrek merged commit 977fd22 into tycrek:dev/0.15.0 Oct 13, 2023
4 checks passed
@Gauvino Gauvino deleted the docker-build branch October 14, 2023 18:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants