This repository has been archived by the owner on Dec 19, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 53
Optimize docker image and update package #244
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tycrek
added
the
merge conflict
Automatically applied to PR's with merge conflicts
label
Oct 26, 2023
[AUTOMATED MESSAGE] 🔴 This Pull Request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
tycrek
removed
the
merge conflict
Automatically applied to PR's with merge conflicts
label
Oct 26, 2023
[AUTOMATED MESSAGE] 🟢 Conflicts have been resolved. |
tycrek
added
the
merge conflict
Automatically applied to PR's with merge conflicts
label
Oct 27, 2023
[AUTOMATED MESSAGE] 🔴 This Pull Request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
[AUTOMATED MESSAGE] 🟢 Conflicts have been resolved. |
tycrek
removed
the
merge conflict
Automatically applied to PR's with merge conflicts
label
Oct 27, 2023
Go look on discord before merging ! @tycrek |
tycrek
reviewed
Oct 27, 2023
tycrek
approved these changes
Oct 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Enviroment
Description
This PR update the repository to nodejs 20.9, npm 10.2.1 and all the sub package, adds .dockerignore file to remove form the built image the useless file and changed the node based image to alpine for having a really lightweight image and efficient one reducing the size overall by almost 1Gb (as you can see in the screenshot below)
(Don't forget to edit the descripition of the [dev/0.15.0] PR)
Tested the image on Docker Desktop (v24.0.6) on Windows (11) and on Ubuntu 23.10 (Mantic) (v24.0.6)
Superseded: #246