Use content tag

[NullVoxPopuli]

Resolves: #609
Blocked by: embroider-build/content-tag#19
Blocked by: embroider-build/content-tag#31

Unblocks: NullVoxPopuli/polaris-starter#11

Problem:

• content-tag requires syntax to be correct
• LSPs need fault-tolerant parsing to aid in intellisense, suggestions and all that

This isn't a new problem for Glint, but it does take things in the wrong direction a bit.

[dfreeman]

• content-tag requires syntax to be correct
• LSPs need fault-tolerant parsing to aid in intellisense, suggestions and all that

This isn't a new problem for Glint, but it does take things in the wrong direction a bit.

Based on Ed's research yesterday, it sounds like this isn't quite true, which is great news!

[dfreeman]

Can we have content-tag expose this type itself, either by generating it from the underlying Rust struct(s) or something like #[wasm_bindgen(typescript_custom_section)]?

[NullVoxPopuli]

I think so -- tho I don't know how specific we'd get. @ef4 said an update to one of the build tools would give us better types when updated.

It's also totally reasonable for us to ship our own d.ts, and ignore the generated one.

[dfreeman]

I'm not too hung up on any specific approach on the content-tag side; it just makes me nervous to be encoding assumptions here that could break at any time 😅

[NullVoxPopuli]

Observations:

Deleting the closing </template>

Example 1

kinda goofy

Before this PR, the experience is worse

Example 2

this actually makes sense and provides meaningful feedback about the missing closing </template>, which I believe is an improvement?

Before this PR, the experience is worse

Deleting the opening <template>

Example 1

sqigglies everywhere.
maybe this is something we can get our swc parser to help with though?

Before this PR, the experience is not helpful, but 🤷 when it comes to deciding if better or worse, imo

Deliberate syntax error

"importing a number"

Before this PR, the experience is better

extra quote

Before this PR, the experience is better

number * string

Before this PR, the experience is better

forgetting to give a variable a value

Before this PR, the experience is better

fun thing(s)

accidentally discovered function noop shorthand

this is actually valid, but looks goofy

[NullVoxPopuli]

I broke something here, so I'm starting over here: #655