This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Implement UserManager #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
dmitrii-ubskii
suggested changes
Jul 5, 2023
dmikhalin
commented
Jul 5, 2023
Comment on lines
+110
to
+112
| pub async fn cleanup_databases(&mut self) { | ||
| try_join_all(self.databases.all().await.unwrap().into_iter().map(Database::delete)).await.ok(); | ||
| } |
There was a problem hiding this comment.
We ignore possible errors that could appear when database is still in all() but is already deleted.
.factory/automation.yml
Outdated
Comment on lines
100
to
102
| source tools/start-cluster-servers.sh # use source to receive export vars | ||
| bazel test //tests --test_env=ROOT_CA=$ROOT_CA --test_arg=-- --test_arg=behaviour::concept --test_arg=--test-threads=1 --test_output=streamed && export TEST_SUCCESS=0 || export TEST_SUCCESS=1 | ||
| tools/stop-cluster-servers.sh |
There was a problem hiding this comment.
we should make two sets of tests in automation.yml: one for cluster (test-behaviour-concept-cluster) and (test-behaviour-concept-core)
Same pattern for behaviour-typeql and the rest
There was a problem hiding this comment.
We decided that it's out of the scope now. https://github.com/vaticle/typedb-client-rust/issues/52
flyingsilverfin
suggested changes
Jul 6, 2023
.factory/automation.yml
Outdated
Comment on lines
113
to
114
| source tools/start-cluster-servers.sh # use source to receive export vars | ||
| bazel test //tests --test_env=ROOT_CA=$ROOT_CA --test_arg=-- --test_arg=behaviour::connection --test_arg=--test-threads=1 --test_output=streamed && export TEST_SUCCESS=0 || export TEST_SUCCESS=1 |
There was a problem hiding this comment.
I've made a comment on typedb/typedb-common#147 to implement root CA & TLS support in the TypeDB runner. I don't think it currently is able to do that.
.factory/automation.yml
Outdated
| bazel test //tests --test_arg=-- --test_arg=behaviour::concept --test_arg=--test-threads=1 --test_output=streamed && export TEST_SUCCESS=0 || export TEST_SUCCESS=1 | ||
| tools/stop-core-server.sh | ||
| source tools/start-cluster-servers.sh # use source to receive export vars | ||
| bazel test //tests --test_env=ROOT_CA=$ROOT_CA --test_arg=-- --test_arg=behaviour::concept --test_arg=--test-threads=1 --test_output=streamed && export TEST_SUCCESS=0 || export TEST_SUCCESS=1 |
There was a problem hiding this comment.
couple more extra --test-threads=1 here and below
flyingsilverfin
approved these changes
Jul 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
We implement
UserManager.What are the changes implemented in this PR?
We implemented:
Userstruct andUserManagerAs
UserManagerBDD scenarios have to be run ontypedb-cluster, we changed the default connection inContextto cluster connection, and run all behaviour tests on cluster. We added waiting to some steps because of eventual consistency oftypedb-cluster.