Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new property namespace to index definitions #325

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Conversation

tywalch
Copy link
Owner

@tywalch tywalch commented Nov 12, 2023

This property allows users to further isolate partition keys beyond just service participation. This implements an RFC that was thoughtfully put forward by @Sam3d in Issue #290.

This property allows users to further isolate partition keys beyond just `service` participation. This implements an RFC that was thoughtfully put forward by [@sam3d](https://github.com/sam3d) in [Issue #290](#290).
Copy link

netlify bot commented Nov 12, 2023

Deploy Preview for electrodb-dev ready!

Name Link
🔨 Latest commit 1c744a7
🔍 Latest deploy log https://app.netlify.com/sites/electrodb-dev/deploys/655232d66e2ee2000805db03
😎 Deploy Preview https://deploy-preview-325--electrodb-dev.netlify.app/en/modeling/indexes
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tywalch tywalch linked an issue Nov 12, 2023 that may be closed by this pull request
@tywalch tywalch changed the title Adds new property scope to index definitions Adds new property namespace to index definitions Nov 12, 2023
@tywalch tywalch linked an issue Nov 12, 2023 that may be closed by this pull request
Copy link

@sam3d sam3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(re: calling it scope instead of namespace) I was thinking the same thing 🎉

@tywalch
Copy link
Owner Author

tywalch commented Nov 13, 2023

(re: calling it scope instead of namespace) I was thinking the same thing 🎉

Yeah, I always try to sleep on things like this 😅

@sam3d
Copy link

sam3d commented Nov 13, 2023

I read somewhere that sleep helps 😌

@sam3d
Copy link

sam3d commented Nov 13, 2023

Btw I've just tested this PR, and it successfully replaces every single use of template left in my app 🥳

@tywalch tywalch merged commit 2f5cfd0 into master Nov 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modeling single-partition data RFC: Add support for namespacing partitions
2 participants