Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add regdis checkerboard test #11

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add regdis checkerboard test #11

wants to merge 2 commits into from

Conversation

ayanori
Copy link
Collaborator

@ayanori ayanori commented Aug 11, 2024

Added transform_order_natural2regdis and transform_order_regdis2natural functions that allow direct forward modelling in regdis class without the need of initializing okada models for patches.

Added a checkerboard test to show model capability.

@ayanori ayanori requested a review from mfangaritav August 11, 2024 00:13
mfangaritav
mfangaritav requested changes Aug 25, 2024
View reviewed changes
Copy link
Collaborator

@mfangaritav mfangaritav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the notebook and I ran a non-linear squares inversion but it seems like the synthetic data is not being loaded into the insarobs object, so maybe the version that is in this PR was not the one that was used in the mcmc inversion?

@mfangaritav
Copy link
Collaborator

Also, I added some of the changes that you suggested to regdis.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfangaritav mfangaritav mfangaritav requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayanori @mfangaritav