Screen flashes bright white on taking picture

[mateosalta]

was implemented as a feature to light up dark selfies however:

• activates on rear camera as well
• activates with flash off
• is not timed with the activation of the picture, so does not serve original dark selfie purpo
• in "no flash" areas of aquarium/museum staff mistake screen flashing for the flash being on

#38

[dark-eye]

The above PR was merged as a temporary fix.
The real fix should be to only enable the screen flash when the user selected to enable it and that its actually helpful (i.e. The picture is taken from a selfie camera so the subject can be illuminated by the screen ).

It be a good idea to add a new button in the quick options to allow the user to manage the screen flash.

Also if possible (probably not due to confinement) use maximum / adjustable screen brightness.

@mateosalta Thanks for the fix 👍 do you want to take the rest?

[mateosalta]

cool, working on it. Currently have a button that will turn it on/off, made a new icon.

Need to find a way to turn it off when using the camera facing away from the screen, I first tried using

property bool available: !camera.advanced.hasFlash

but this will only make the button unavailable and will keep the previous setting. Ideas on where to trigger clearing the setting?

mateosalta@2122fb4

Then I will have to test and adjust the animation duration so it will light up the subject

[dark-eye]

Thanks for the help! the icon looks great 👍

To turn it of when not using the selfie camera you can use the 'camera.position === Camera.FrontFace' expression so the available property will be :
property bool available: (!camera.advanced.hasFlash && camera.position === Camera.FrontFace)
I also suggest adding it to the indicators with : property bool showInIndicators: true

No need to clear the settings you can just add the camera.position test to the shootFeedback white / black check so it will only be white if the setting is selected and the camera.position is FrontFace

Regarding the flash duration you don't have to fix it, as fixing it require some refactoring to the shooting code as in my device case (Miezu PRO 5) the picture is taken 10-50 milis (depending on exposure) before the shoot button is clicked, I`ll digg into to it during the weekend.

[Flohack74]

Wouldnt it be possible to put a shim around the click of the button and then activate the white screen? Is the button click in our app or is this directly going to Android part?

[dark-eye]

@Flohack74 it`s possible (already done actually need some more testing...) I've added an (ugly) hack that will activate the white screen in case it is on and the camara is a front/seflie camera and then wait for 66 miliseconds before actually taking the shoot.

[mateosalta]

Mine is a pro 5 as well.
Ah, so any flash effect done on screen after the button is pressed is too late for that device, at first I thought it might be early, interesting.

[mateosalta]

nice, I like the icons for on and off, and I think yours will look better at small size.

[dark-eye]

Oh ignore that just uploaded some test so I can work on them on another computer theres still issues with the shutter timing as it seems theres no support for camera.exposure.shutterSpeed variable in meizu pro 5

I liked your icon alot more then mine I think you shold do the UI i`m just working on solving the shutter and screen flash sync.