This repository has been archived by the owner on Jan 7, 2019. It is now read-only.
fix screen flash #38
Merged
fix screen flash #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might want to wait for @dark-eye 's opinion too Comment no. 2 in the Launchpad.net page might also require further actions. It seems a nice feature to have :) |
|
Yeah, I like the idea of a selfie flash. I'll try to test more to find something that works for that. And then we can put it in on facing camera only (Also note that current android versions do not flash the screen white for comparison reference) |
|
Hey yeah i also like the idea of the screen flash but it might be a good idea to only use it if the camera has no flash and is a selfie camera and the user choose auto flash/flash no in the quick options. I think that we can merge this PR and create a new issue to bring back the white screen flash under the right conditions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change flashing screen from white to black to fix regressions from non working feature: https://bugs.launchpad.net/camera-app/+bug/1124574
#39