-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
volla-mimameid: fix coming (back) from Android #238
Conversation
peat-psuwit
commented
Jun 20, 2023
•
edited
Loading
edited
- If the current slot is 'b' (as it can be if Android has been updated), even if we set the (new) active slot to 'a', we still have to explicitly spell out the slot.
- vbmeta has to be flashed, replacing the one from Android. The new bootstrap tarball is provided by Volla to include vbmeta.
Can you tell me the rationale why it is necessary to spell the slot out after switching it explicitly to a? Also, should the Droidian installation part be updated as well to do the same? |
Can't really comment on Specifying the slot explicitly always works on these buggy implementations. |
On Volla Phone 22, its bootloader seems to flash to the currently booted slot, rather than the set-to-be-active slot. For example, if booted as slot
Not sure... I guess I'll have to test, although I don't have a VP22 on hand at the moment. You may try to reproduce this by flashing Android and then do the upgrade once. |
@peat-psuwit , in that case, I believe it would be necessary to specifically use the slot suffix on boot, dtbo, and vbmeta when installing Droidian. |
ee5c452
to
293122d
Compare
Ok. Droidian section also updated to use |
LGTM now. |
293122d
to
fc3aa0d
Compare
@erikinkinen ping, please. |
Any reason this is still pending? If Droidian is the blocker I propose moving changes for that to a new PR where it can be finished |
Droidian should be dropped from mimameid config anyways. Droidian image generation for mimameid was temporarily halted due to a serious bug found in the adaptation. |
@erikinkinen I believe you now have it running again (without LVM), is there anything to do here? I know https://github.com/droidian-releng/droidian-installer & https://github.com/droidian-devices/installer-configs exists as well now, should it be removed or leave a "dummy entry" with a message pointing to use Droidian installer instead? |
@JamiKettunen , the configs need to be updated and I will open another PR once I have done that. |
Ping @peat-psuwit, I think the way forward and finally get this merged is to drop Droidian entirely from the config for now and add it back later once it's back in working order again |
@peat-psuwit Should I resubmit this PR with the change I proposed in my previous message? |
Now that CI is working again, are there any updates? :) |
- If the current slot is 'b' (as it can be if Android has been updated), even if we set the (new) active slot to 'a', we still have to explicitly spell out the slot, otherwise bootloader will still flash to slot b. - vbmeta has to be flashed, replacing the one from Android. The new bootstrap tarball is provided by Volla to include vbmeta.
fc3aa0d
to
724b5b4
Compare
Thanks! :) |