Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volla-mimameid: fix coming (back) from Android #238

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

peat-psuwit
Copy link
Contributor

@peat-psuwit peat-psuwit commented Jun 20, 2023

  • If the current slot is 'b' (as it can be if Android has been updated), even if we set the (new) active slot to 'a', we still have to explicitly spell out the slot.
  • vbmeta has to be flashed, replacing the one from Android. The new bootstrap tarball is provided by Volla to include vbmeta.

@erikinkinen
Copy link
Contributor

Can you tell me the rationale why it is necessary to spell the slot out after switching it explicitly to a? Also, should the Droidian installation part be updated as well to do the same?

@amartinz
Copy link
Member

Can you tell me the rationale why it is necessary to spell the slot out after switching it explicitly to a? Also, should the Droidian installation part be updated as well to do the same?

Can't really comment on mimameid but some bootloader implementations are buggy and require to reboot into bootloader to detect switching slots and may flash a different slot.

Specifying the slot explicitly always works on these buggy implementations.
Even if not working around a buggy bootloader, it better expresses what is meant to happen.

@peat-psuwit
Copy link
Contributor Author

peat-psuwit commented Jun 26, 2023

Can you tell me the rationale why it is necessary to spell the slot out after switching it explicitly to a?

On Volla Phone 22, its bootloader seems to flash to the currently booted slot, rather than the set-to-be-active slot. For example, if booted as slot b, fastboot flash boot <image> will always flash to boot_b, even though fastboot set_active a is already run. I don't know why; buggy firmware? (That said, what defines this behavior in fastboot?)

Also, should the Droidian installation part be updated as well to do the same?

Not sure... I guess I'll have to test, although I don't have a VP22 on hand at the moment. You may try to reproduce this by flashing Android and then do the upgrade once.

@erikinkinen
Copy link
Contributor

@peat-psuwit , in that case, I believe it would be necessary to specifically use the slot suffix on boot, dtbo, and vbmeta when installing Droidian.

@peat-psuwit peat-psuwit force-pushed the personal/peat-psuwit/from-android-slot-b branch from ee5c452 to 293122d Compare June 28, 2023 10:00
@peat-psuwit
Copy link
Contributor Author

Ok. Droidian section also updated to use _a suffix.

@erikinkinen
Copy link
Contributor

Ok. Droidian section also updated to use _a suffix.

LGTM now.

@peat-psuwit peat-psuwit force-pushed the personal/peat-psuwit/from-android-slot-b branch from 293122d to fc3aa0d Compare July 17, 2023 18:53
@peat-psuwit
Copy link
Contributor Author

@erikinkinen ping, please.

@JamiKettunen
Copy link
Contributor

Any reason this is still pending? If Droidian is the blocker I propose moving changes for that to a new PR where it can be finished

@erikinkinen
Copy link
Contributor

Droidian should be dropped from mimameid config anyways. Droidian image generation for mimameid was temporarily halted due to a serious bug found in the adaptation.

@JamiKettunen
Copy link
Contributor

@erikinkinen I believe you now have it running again (without LVM), is there anything to do here? I know https://github.com/droidian-releng/droidian-installer & https://github.com/droidian-devices/installer-configs exists as well now, should it be removed or leave a "dummy entry" with a message pointing to use Droidian installer instead?

@erikinkinen
Copy link
Contributor

@JamiKettunen , the configs need to be updated and I will open another PR once I have done that.

@JamiKettunen
Copy link
Contributor

Ping @peat-psuwit, I think the way forward and finally get this merged is to drop Droidian entirely from the config for now and add it back later once it's back in working order again

@JamiKettunen
Copy link
Contributor

@peat-psuwit Should I resubmit this PR with the change I proposed in my previous message?

@amartinz
Copy link
Member

amartinz commented Mar 7, 2024

Now that CI is working again, are there any updates? :)

@erikinkinen
Copy link
Contributor

@amartinz , regarding the Droidian situation, #257 should fix that. AFAIK, that was the only blocker here.

- If the current slot is 'b' (as it can be if Android has been updated),
  even if we set the (new) active slot to 'a', we still have to
  explicitly spell out the slot, otherwise bootloader will still
  flash to slot b.
- vbmeta has to be flashed, replacing the one from Android. The new
  bootstrap tarball is provided by Volla to include vbmeta.
@peat-psuwit peat-psuwit force-pushed the personal/peat-psuwit/from-android-slot-b branch from fc3aa0d to 724b5b4 Compare March 7, 2024 19:22
@peat-psuwit
Copy link
Contributor Author

The PR is rebased, and the commit message is updated to correctly refer to the new bootstrap tarball. Since #257 seems to be made on top of this PR, I think this one should go in first, then #257 can be rebased and merged.

@erikinkinen
Copy link
Contributor

The PR is rebased, and the commit message is updated to correctly refer to the new bootstrap tarball. Since #257 seems to be made on top of this PR, I think this one should go in first, then #257 can be rebased and merged.

Yes, that was my intention on #257 .

@amartinz
Copy link
Member

amartinz commented Mar 7, 2024

Thanks! :)

@amartinz amartinz merged commit 6b10da0 into master Mar 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants