Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/datasets correctly return an error when no 'nodes' parameter. #202

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

paulineribeyre
Copy link
Contributor

Bug: if nodes == "", then nodes.split(",") == [""] and we don't run the if not nodes statement

Bug Fixes

  • Fix /datasets to correctly return an error when no nodes parameter is provided

@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

ocshawn
ocshawn previously approved these changes Jul 26, 2023
@haraprasadj haraprasadj changed the title /datasets correctly return an error when no 'nodes' parameter /datasets correctly return an error when no 'nodes' parameter. Jul 26, 2023
@paulineribeyre paulineribeyre merged commit 1bf2dc4 into master Jul 27, 2023
4 checks passed
@paulineribeyre paulineribeyre deleted the fix/datasets-nodes branch July 27, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants