Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample (+ Outlier Functionality) Operation #100

Merged
merged 22 commits into from
Oct 14, 2024
Merged

Sample (+ Outlier Functionality) Operation #100

merged 22 commits into from
Oct 14, 2024

Conversation

shreyashankar
Copy link
Collaborator

@shreyashankar shreyashankar commented Oct 12, 2024

I've combined the Sample and Outliers Operators into one (Sample). LMK what you think.

@shreyashankar shreyashankar changed the title WIP: Sample and Outliers Operations Sample and Outliers Operations Oct 12, 2024
@shreyashankar shreyashankar changed the title Sample and Outliers Operations Sample (+ Outlier Functionality) Operation Oct 12, 2024
@redhog
Copy link
Collaborator

redhog commented Oct 13, 2024

So, you have

- type: sample
  outliers:
    samples: 0.9

for removing 10% outliers vs

- type: sample
  samples: 0.9

for removing 10% random samples.

Wouldn't it be better to specify size with samples at the toplevel, and then say how you want to sample separately:

  • sample: randomly
  • sample: stratified
  • sample: outliers
  • sample: non-outliers

or some such?

What about specifying an explicit center btw? You want that part of another operation, or you don't want it at all?

@shreyashankar
Copy link
Collaborator Author

Good catch; I forgot the center logic!

@shreyashankar shreyashankar merged commit 10a841c into main Oct 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants