Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing issue unresolve bug and adding concept of scanIssue/decreased … #873

Closed
wants to merge 1 commit into from

Conversation

atarisafari
Copy link
Contributor

…amount of intial data on issue load

Fixes: #867

Adds concept of loading less issue data on initial app load, but scanning for further issue data when the issue is opened in the modal.

@bagofarms bagofarms changed the base branch from dev/v3-3-1 to main December 19, 2022 19:30
@taheralfayad
Copy link
Contributor

taheralfayad commented Dec 20, 2022

Whenever I try to run UDOIT on the cidilabs:fixUnresolveBug branch, I, for some reason, am not able access any of the issues and the issue window loading screen just loops infinitely. PHP just returns a 404 error.

Screen Shot 2022-12-20 at 11 03 27 AM

Screen Shot 2022-12-20 at 11 03 36 AM

@atarisafari
Copy link
Contributor Author

@taheralfayad I'll take a look, thanks for pointing that out.

let showExample = false
if (!this.props.t(`rule.example.${activeIssue.scanRuleId}`).includes('rule.example')) {
showExample = true
}

let code = this.prepareCode(activeIssue)
if (!this.state.issueDetailsPending) {
UfixitForm = ufixitService.returnIssueForm(activeIssue)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot find ufixitService anywhere in the React files, only on this line. Returns an error:

Uncaught (in promise) ReferenceError: ufixitService is not defined
    at a.value (app.js:252:268294)
    at Pa (app.js:377:69887)
    at Na (app.js:377:69682)
    at gs (app.js:377:105481)
    at cl (app.js:377:96728)
    at sl (app.js:377:96653)
    at Zs (app.js:377:93683)
    at app.js:377:45325
    at t.unstable_runWithPriority (app.js:11:3844)
    at Fi (app.js:377:45034)

Copy link
Contributor

@dmols dmols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that like @taheralfayad, I also get the infinite loop upon clicking on any issue, as well as a 404 error in the logs.

@dmols
Copy link
Contributor

dmols commented Jun 22, 2023

Hey @atarisafari, it's been a while since this PR has had any updates but have you by any chance been able to test the issue @taheralfayad and I were having, regarding the immediate infinite loading screen? I'm unable to test the branch as is. Thank you!

@dmols
Copy link
Contributor

dmols commented Jul 25, 2024

Hey @atarisafari, thank you for working on this issue, though I'm not able to test the fix since @taheralfayad and I get an infinite loading screen and 404 error when we try to load issues on UFIXIT. I'll close this and likely make another branch/PR in the future to look into the issue closer. Please let me know if you'd like to troubleshoot the roadblock on your branch! I'd be happy to assist and reopen the PR if we can get past that.

@dmols dmols closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-resolving issues leads to spinning UI state, 404 in backend
3 participants