Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a full rescan option to UDOIT #898

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Add a full rescan option to UDOIT #898

merged 5 commits into from
Apr 18, 2024

Conversation

taheralfayad
Copy link
Contributor

With the intent to tackle #871 , I created a full course rescan option in UDOIT that deletes all the reports belonging to a course, and generates a new report in their stead. This solves the bug that we were encountering wherein adding a Youtube API key to the .env file after a course has been scanned does not automatically trigger a rescan of the course, and therefore, UDOIT misses issues that pertain to youtube captioning.

@taheralfayad taheralfayad added bug javascript Pull requests that update Javascript code php Pull requests that update Php code labels Mar 24, 2023
@taheralfayad taheralfayad linked an issue Mar 24, 2023 that may be closed by this pull request
@dmols dmols self-requested a review June 30, 2023 19:27
Copy link
Contributor

@dmols dmols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full rescan works as intended; fills issue list with new issues relating to captioning if a youtube API key is placed in the env file. Great addition! Clear to push.

@dmols dmols requested review from dmols and removed request for bagofarms April 16, 2024 13:11
@dmols dmols changed the base branch from main to dev April 17, 2024 21:50
@dmols dmols self-assigned this Apr 17, 2024
@dmols
Copy link
Contributor

dmols commented Apr 17, 2024

Changes look good! Added the spanish translation and now it should be good to go. I'll merge it after clearing the other PR.

Copy link
Contributor

@dmols dmols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra changes needed were added. Clear to push!

@dmols dmols merged commit 28bf1f0 into dev Apr 18, 2024
2 checks passed
@dmols dmols deleted the issue/871-full-rescan branch November 12, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug javascript Pull requests that update Javascript code php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a YouTube API key after scanning does not rescan videos
2 participants