Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Fix unclosed brackets preventing text from rendering properly on health general page #290

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

klinkoberstar
Copy link
Contributor

This PR closes #284

Describe your changes

A few of the text fields were missing leading brackets, preventing Babel from picking up translatable text. This PR fixes this bug

In the course of fixing this bug I also noticed that the buttons on the health page were not retaining the selected language on click because it was still using this approach:

onclick="navigateTo('/health_general', '{{ language | escape }}')"

instead of:

onclick="navigateTo('/health/general', '{{ get_locale() }}')"

This bug has been fixed as well!

Non-obvious technical information

Checklist before requesting a review

  • pre-commit run --all-files (run before pushing)
  • pytest if applicable
  • Link issue
  • Update relevant documentation if applicable: doc strings, readme, poetry.

@klinkoberstar klinkoberstar linked an issue Aug 5, 2024 that may be closed by this pull request
@klinkoberstar klinkoberstar marked this pull request as ready for review August 5, 2024 14:08
@klinkoberstar klinkoberstar requested a review from CaitlinCP August 5, 2024 14:08
@klinkoberstar klinkoberstar self-assigned this Aug 5, 2024
@klinkoberstar klinkoberstar added the bug Something isn't working label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bug): Babel syntax typo on health information page
1 participant