Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align Hash #1

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Align Hash #1

merged 1 commit into from
Feb 2, 2024

Conversation

ajnelson-nist
Copy link
Contributor

No description provided.

@ajnelson-nist
Align Hash
8c15a47 
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Copy link
Contributor Author

There is a deeper conversation to be had on whether types:Hash should further always be a subclass of gufo:QualityValue.

plbt5
plbt5 approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@plbt5 plbt5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Alex' comment on the deeper discussion in place, there's nothing wrong here

@plbt5 plbt5 merged commit 2ee1562 into main Feb 2, 2024
1 check passed
@plbt5 plbt5 deleted the align_hash branch February 2, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plbt5 plbt5 plbt5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajnelson-nist @plbt5