Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply EndurantType hierarchy for Qualities of vehicle example #6

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Apply EndurantType hierarchy for Qualities of vehicle example #6

merged 2 commits into from
Mar 8, 2024

Conversation

ajnelson-nist
Copy link
Contributor

This PR exercises some of the qualities discussion for the bearing and velocity proposal UCO Issue 567, and exercises some of the gufo:Type hierarchy. gufo:Kind usage in this PR's patch might assist with deciding #5 .

@ajnelson-nist
Apply EndurantType hierarchy for Qualities of vehicle example
d8afa8e 
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#567

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist marked this pull request as ready for review March 5, 2024 20:18
@ajnelson-nist ajnelson-nist requested a review from a team as a code owner March 5, 2024 20:18
@ajnelson-nist
Copy link
Contributor Author

@plbt5 , if you agree, please feel free to merge.

@ajnelson-nist ajnelson-nist mentioned this pull request Mar 5, 2024
Merged
plbt5
plbt5 requested changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@plbt5 plbt5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments inline

@ajnelson-nist
Restrict gufo:inheresIn and restore profile-level shapes
22b71d5 
Suggested-by: Paul Brandt <paul@brandt.name>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
plbt5
plbt5 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@plbt5 plbt5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've identified a way forward without being dependent on future decisions by gUFO on the identified issues. If gUFO will respond to our issue with a change, it's easy to include those changes in this UCO-profile then.

@plbt5 plbt5 merged commit 3c7c89a into main Mar 8, 2024
1 check passed
@plbt5 plbt5 deleted the Kinds-and-UCO-Issue-567 branch March 8, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plbt5 plbt5 plbt5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajnelson-nist @plbt5