Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified and intuitive data check for Cursor. #42

Open
wants to merge 1 commit into
base: student
Choose a base branch
from
+5 −11
Open

Simplified and intuitive data check for Cursor. #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions ...5-Solution-MoreDetails/app/src/main/java/com/example/android/sunshine/DetailActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,23 +242,17 @@ public void onLoadFinished(Loader<Cursor> loader, Cursor data) {
/*
* Before we bind the data to the UI that will display that data, we need to check the
* cursor to make sure we have the results that we are expecting. In order to do that, we
* check to make sure the cursor is not null and then we call moveToFirst on the cursor.
* Although it may not seem obvious at first, moveToFirst will return true if it contains
* a valid first row of data.
* check to make sure the cursor is not null and is not empty.
*
* If we have valid data, we want to continue on to bind that data to the UI. If we don't
* have any data to bind, we just return from this method.
*/
boolean cursorHasValidData = false;
if (data != null && data.moveToFirst()) {
/* We have valid data, continue on to bind the data to the UI */
cursorHasValidData = true;
}

if (!cursorHasValidData) {
if (data == null || data.getCount() == 0) {
/* No data to display, simply return and do nothing */
return;
}
/* We have valid data, point the cursor to the first row and continue on to bind the data to the UI */
data.moveToFirst();

// COMPLETED (26) Display a readable data string
/****************
Expand Down Expand Up @@ -381,4 +375,4 @@ public void onLoadFinished(Loader<Cursor> loader, Cursor data) {
@Override
public void onLoaderReset(Loader<Cursor> loader) {
}
}
}