Merge pull request #27 from dbohn/fix-invalid-codeblock-parsing

Don't fail on missing code tag in code block parsing
ueberdosis · Aug 12, 2024 · c9e4d37 · c9e4d37
2 parents 303877d + d7d6303
commit c9e4d37
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/src/Nodes/CodeBlock.php b/src/Nodes/CodeBlock.php
@@ -33,6 +33,10 @@ public function addAttributes()
         return [
             'language' => [
                 'parseHTML' => function ($DOMNode) {
+                    if (!($DOMNode->childNodes[0] instanceof \DOMElement)) {
+                        return null;
+                    }
+
                     return preg_replace(
                         "/^" . $this->options['languageClassPrefix']. "/",
                         "",

diff --git a/tests/DOMParser/Nodes/CodeBlockTest.php b/tests/DOMParser/Nodes/CodeBlockTest.php
@@ -123,3 +123,24 @@
         ],
     ]);
 });
+
+test('it handles code blocks without a code tag', function () {
+    $html = '<pre>body { display: none }</pre>';
+
+    $result = (new Editor)->setContent($html)->getDocument();
+
+    expect($result)->toEqual([
+        'type' => 'doc',
+        'content' => [
+            [
+                'type' => 'codeBlock',
+                'content' => [
+                    [
+                        'type' => 'text',
+                        'text' => 'body { display: none }',
+                    ],
+                ],
+            ],
+        ],
+    ]);
+});