Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump ui5, tooling and wdi5 versions #315

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

wridgeu
Copy link
Contributor

@wridgeu wridgeu commented Aug 5, 2023

For fixing the wdi5 tests on #314 I bumped the UI5, wdi5, UI5 tooling and a few other versions. Some version conflict with newest wdio & wdi5 or prettier with pretty-quick were also resolved (no mindless full bump).

I did not bump any action and therefore no node or action versions though. Two tests which relied on virtual list items (clones) were made more resilient by ignoring the clone id at the end. These sporadically failed for me.

Locally it all passed, several times

Spec Files:      5 passed, 1 skipped, 6 total (100% completed) in 00:00:44

Disclaimer

I did not comb through the entire codebase to clean up or "migrate" types or anything but it still seemed to work just fine. ^^

Hope it helps a bit.

@wridgeu wridgeu requested a review from marianfoo August 5, 2023 20:13
@wridgeu
Copy link
Contributor Author

wridgeu commented Aug 5, 2023

Interesting that it still fails ... but it looks to me like the start of the app takes a bit longer and the testing begins too soon? 🤔 Locally it simply works using npm run start:test and after everything has started npm run test.

@wridgeu
Copy link
Contributor Author

wridgeu commented Aug 5, 2023

Interesting that it still fails ... but it looks to me like the start of the app takes a bit longer and the testing begins too soon? 🤔 Locally it simply works using npm run start:test and after everything has started npm run test.

Guess that was it. Added wait-on as devDep in bc556a9

@marianfoo marianfoo merged commit 35c084f into ui5-community:main Nov 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants