Keybindings should provide Action to command bar #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulyssa
force-pushed
the
custom-cmdbar-actions
branch
2 times, most recently
from
6b59bc3
to
0ac20d4
Compare
ulyssa
force-pushed
the
custom-cmdbar-actions
branch
from
0ac20d4
to
60cc68d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to jumping through a buffer to matching regular expressions, Kakoune can perform other actions that all use the same search regex history and interact with the same register (see #62 and #63 for example).
In order to support these, focusing the command bar should specify the action to take when submitting its contents. I've replaced
Register::LastSearch("/) andRegister::LastCommand(":) with aRegister::LastCommand(CommandType)variant. History for their contents has also moved into theRegisterStore, and is done in a way that should make #69, #130, and any other new command bar types very straightforward to implement.