Publish NPM package for deployment #270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
% npm install $HOME/dev/umccr/htsget-rs/deploy/ npm error Invalid Version: 1.0
fix: c4gh deploy
chore: release
… for easy deploy (reasonable defaults)
Removing unnecessary BAM symlinks under crypt4gh data. Co-authored-by: Marko Malenic <mmalenic1@gmail.com>
fix(deploy): allow fetching C4GH and regular files
… one... this setting should probably be called 'usePreExistingHostedZone' I reckon?
…e to copying local keys
% npm install $HOME/dev/umccr/htsget-rs/deploy/ npm error Invalid Version: 1.0
… for easy deploy (reasonable defaults)
% npm install $HOME/dev/umccr/htsget-rs/deploy/ npm error Invalid Version: 1.0
… for easy deploy (reasonable defaults)
Removing unnecessary BAM symlinks under crypt4gh data. Co-authored-by: Marko Malenic <mmalenic1@gmail.com>
… one... this setting should probably be called 'usePreExistingHostedZone' I reckon?
… for easy deploy (reasonable defaults)
…into npmjs_deploy_publishing
… perhaps we should parametrise those secret manager paths if they are not already @mmalenic?
…the full non-functional refactoring route. Co-authored-by: Marko Malenic <mmalenic1@gmail.com>
* Use package.json "files" directive to whitelist what to publish to npmjs.com. * Comment examples on settings.js and cleanup to guide user with settings (especially cognito ones) * Shipping example deploy config, needs to be migrated to stack directives and the following warnings must be addressed: npm warn package-json htsget-lambda@0.5.1 No bin file found at bin/htsget-lambda.js npm warn package-json htsget-lambda@0.5.1 No bin file found at bin/htsget-lambda.js npm warn package-json htsget-lambda@0.5.1 No bin file found at bin/htsget-lambda.js npm warn package-json htsget-lambda@0.5.1 No bin file found at bin/htsget-lambda.js
…construct, we'll eventually split this deploy folder into a separate repo
… htsget-rs-deploy repository, thanks to cargo-lambda/cargo-lambda-cdk#57 and up to PR #68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #269