Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cacheTag suport #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add cacheTag suport #56

wants to merge 2 commits into from

Conversation

gotson
Copy link

@gotson gotson commented Aug 23, 2021

should close #55

@gotson
Copy link
Author

gotson commented Aug 24, 2021

I was thinking we could also use the image tag (instead if latest) instead of changing the slug. Let me know which you prefer.

martin-g
martin-g approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@martin-g martin-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks like a more generic solution than #100.

Just one comment: instead of using 'default' as a default cache tag I suggest to use env.GITHUB_JOB

@uraimo uraimo mentioned this pull request Oct 25, 2022
Open
@felfert felfert mentioned this pull request May 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-g martin-g martin-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cache conflict?
2 participants
@gotson @martin-g