-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Jaro-Winkler algorithm usage with an internal function #1893
Conversation
Probably the rate limit was reached in the check and failed. The remaining steps were therefore canceled. |
Please run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the goal to depend on Go's stdlib only :)
suggestions.go
Outdated
// jaroDistance is the measure of similarity between two strings. The result is | ||
// 1 for equal strings, and 0 for completely different strings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add that the result is between 0 or 1. This description at first made me think the output is either 0 or 1, only.
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for contributing :)
Sorry about the trouble with codecov 😩 I'll get a token set up as soon as I can! Update: it's already set up, but I'm assuming the token expired (??) Anyway, I updated it and now I'll re-run the failed checks. Update Update: Uhhhh the token is updated and appears to be in use, and we're still getting rate limit failure. I think the failing step should probably get a Update 3x: #1898 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely, @yigithankarabulut! Thanks so much 🤘🏼
@meatballhat You can be sure there will be more to come. Let's go! |
Go go go! :D |
What type of PR is this?
What this PR does / why we need it:
To support the goal of only requiring the Go standard library. We were using the Jaro-Winkler algorithm for the suggestion from the "xrash/smetrics" package. This function was rewritten to be faithful to stdlib.
Which issue(s) this PR fixes:
Fixes #1892
Testing
go test -run=TestJaroWinkler
Release Notes
(REQUIRED)