Skip to content

Commit

Permalink
Update build.gn for Chromium framework (I think!?) so we can find Syp…
Browse files Browse the repository at this point in the history
…hon.framework for linking. We still need to properly copy the bundle resources (Syphon.framework) and correctly run install_name_tool but we are doing that manually with the loader flags as :

Mayalls-Object:~ vade$ install_name_tool -change Frameworks/Syphon.framework/Versions/A/Syphon @loader_path/Frameworks/Syphon.framework/Versions/A/Syphon /Users/vade/Documents/Chromium/chromium/src/out/Default/Chromium.app/Contents/Versions/58.0.2994.0/Chromium\ Framework.framework/Chromium\ Framework

Assuming the Frameworks/Syphon.framework is next to the Chromium Framework binary.
  • Loading branch information
vade committed Jan 27, 2017
1 parent 79e0868 commit 234a994
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions chrome/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,11 @@ if (is_win) {
group("chrome") {
deps = [
":chrome_app",
# "//third_party/decklink",
# "//third_party/Syphon"
]


data_deps = [
":chrome_app",
]
Expand All @@ -481,8 +484,11 @@ if (is_win) {
":chrome_dump_syms",
]
}


}


if (enable_xpc_notifications) {
bundle_data("chrome_framework_services") {
sources = [
Expand Down Expand Up @@ -702,6 +708,8 @@ if (is_win) {

ldflags = []

ldflags += ["-F"+"../../third_party/Syphon/mac/"]

if (is_component_build) {
ldflags += [
# The helper is in Chromium.app/Contents/Versions/X/Chromium Helper.app/Conents/MacOS/
Expand Down Expand Up @@ -1065,6 +1073,8 @@ if (is_win) {
"-Wl,-order_file," + rebase_path("app/framework.order", root_build_dir),
]

ldflags += ["-F"+"../../third_party/Syphon/mac/"]

if (is_component_build) {
ldflags += [
"-rpath",
Expand Down

0 comments on commit 234a994

Please sign in to comment.