feat(beefy): add safety info #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finnian0826
approved these changes
Oct 16, 2024
| const { category, title, score } = RISKS[risk] | ||
| return { | ||
| // from https://github.com/beefyfinance/beefy-v2/blob/3690e105c4bb98afcf06f9c3e385d13cc23af5cd/src/features/vault/components/SafetyCard/SafetyCard.tsx#L39 | ||
| isPositive: score <= 0, |
There was a problem hiding this comment.
a bit confusing that isPositive is whether the score is <=0 but I think the naming makes sense for what it would be used for, not sure what a better alternative would be
There was a problem hiding this comment.
agree, I added a clarifying comment
jh2oman
reviewed
Oct 16, 2024
| categories[cat].push(risk) | ||
| }) | ||
|
|
||
| // reduce & clamp |
There was a problem hiding this comment.
it's the math.min if the score goes above 1, taken literally from beefy code
jh2oman
reviewed
Oct 16, 2024
| const knownRisks = risks.filter((risk) => !!RISKS[risk]) | ||
|
|
||
| if (knownRisks.length !== risks.length) { | ||
| logger.warn({ vault }, 'Beefy vault has unknown risks') |
jh2oman
reviewed
Oct 16, 2024
Comment on lines
+182
to
+184
| 'Categry-Beefy': 0.2, | ||
| 'Categry-Asset': 0.3, | ||
| 'Categry-Platform': 0.5, |
There was a problem hiding this comment.
Are these typo's or is it literally Categry?
There was a problem hiding this comment.
not sure, just taken directly from beefy codebase, didn't want to change it.
jh2oman
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from beefy codebase, tested by running locally and ensured getEarnPositions returns the expected info for the WETH pool