Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift 6 update #20

Merged
merged 7 commits into from
Sep 21, 2024
Merged

Swift 6 update #20

merged 7 commits into from
Sep 21, 2024

Conversation

fpseverino
Copy link
Member

  • Update package to Swift 6.0
  • Switch from XCTest to Swift Testing
  • Add more test coverage
  • Update to latest AsyncHTTPClient APIs
  • Add support for EU regional subusers
  • Improve DocC

@fpseverino fpseverino added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 18, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c7dda56) to head (a87da0d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##             main       #20       +/-   ##
============================================
+ Coverage   69.44%   100.00%   +30.55%     
============================================
  Files           9         9               
  Lines         108       104        -4     
============================================
+ Hits           75       104       +29     
+ Misses         33         0       -33
Files with missing lines Coverage Δ
...endGridKit/Models/AdvancedSuppressionManager.swift 100.00% <100.00%> (+100.00%) ⬆️
Sources/SendGridKit/Models/EmailAttachment.swift 100.00% <100.00%> (ø)
Sources/SendGridKit/Models/SendGridEmail.swift 100.00% <100.00%> (ø)
Sources/SendGridKit/SendGridClient.swift 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

MahdiBM
MahdiBM requested changes Sep 20, 2024
View reviewed changes
Copy link

@MahdiBM MahdiBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some discussions

Package.swift Show resolved Hide resolved
Sources/SendGridKit/Models/AdvancedSuppressionManager.swift Show resolved Hide resolved
Sources/SendGridKit/Models/SendGridError.swift Outdated Show resolved Hide resolved
Sources/SendGridKit/SendGridClient.swift Show resolved Hide resolved
Sources/SendGridKit/SendGridClient.swift Outdated Show resolved Hide resolved
Tests/SendGridKitTests/SendGridTestsKit.swift Show resolved Hide resolved
Tests/SendGridKitTests/SendGridTestsKit.swift Show resolved Hide resolved
@fpseverino fpseverino requested a review from MahdiBM September 20, 2024 19:45
@fpseverino fpseverino merged commit c00b291 into vapor-community:main Sep 21, 2024
9 of 10 checks passed
@fpseverino fpseverino deleted the swift-6 branch September 21, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MahdiBM MahdiBM MahdiBM approved these changes

@gwynne gwynne Awaiting requested review from gwynne

@0xTim 0xTim Awaiting requested review from 0xTim

@ptoffy ptoffy Awaiting requested review from ptoffy

@Andrewangeta Andrewangeta Awaiting requested review from Andrewangeta Andrewangeta is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fpseverino @gwynne @MahdiBM