Implement preservable jobs and configurable jobs table name #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwynne
force-pushed
the
new-features
branch
from
c4dee44 to
de5af05
Compare
…'s representation. It also helps if when you run tests locally, they actually test something.
… as well as MySQL
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
+ Coverage 92.43% 98.47% +6.03%
==========================================
Files 7 7
Lines 238 262 +24
==========================================
+ Hits 220 258 +38
+ Misses 18 4 -14
|
MahdiBM
approved these changes
Sep 28, 2024
MrLotU
reviewed
Sep 28, 2024
…and ancient MySQL at the same time easier). Add testing of the "space" functionality. Improve test coverage to 98%.
MrLotU
approved these changes
Sep 28, 2024
dimitribouniol
approved these changes
Sep 28, 2024
Yeah what in the Javascript is that about |
... Fine, fine... whining babies... 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserved jobs, if enabled, are marked with a
completedstate in the database. Turning preservation off if it was previously on does not clear old jobs from the table; it just prevents new ones from being preserved.Configuring the jobs table name requires passing the same name (and optionally, space) to both the queue driver and the migration. This is necessary because there's no way for the migration to see the driver's configuration.
Closes #9.
Closes #10.