Skip to content

Commit

Permalink
Merge bitcoin#28184: lint: fix custom mypy cache dir setting
Browse files Browse the repository at this point in the history
f904777 lint: fix custom mypy cache dir setting (Fabian Jahr)

Pull request description:

  fixes bitcoin#28183

  The custom cache dir for `mypy` can only be set via an environment variable, setting the `MYPY_CACHE_DIR` variable in the program is not sufficient. This error was introduced while translating the shell script to python.

  See also the mypy documentation: https://mypy.readthedocs.io/en/stable/config_file.html#confval-cache_dir

ACKs for top commit:
  MarcoFalke:
    lgtm ACK f904777

Tree-SHA512: 7e8fb0cd06688129bd46d1afb8647262eb53d0f60b1ef6f288fedaa122d906fb62c9855e8bb0d6c6297d41a87a47d3cec7a00df55a7d033947937dfe23d07ba7
  • Loading branch information
fanquake committed Oct 2, 2023
2 parents f66af92 + f904777 commit 8b44d01
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion test/lint/lint-python.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,17 @@
"""

import os
from pathlib import Path
import subprocess
import sys

from importlib.metadata import metadata, PackageNotFoundError

# Customize mypy cache dir via environment variable
cache_dir = Path(__file__).parent.parent / ".mypy_cache"
os.environ["MYPY_CACHE_DIR"] = str(cache_dir)

DEPS = ['flake8', 'lief', 'mypy', 'pyzmq']
MYPY_CACHE_DIR = f"{os.getenv('BASE_ROOT_DIR', '')}/test/.mypy_cache"

# All .py files, except those in src/ (to exclude subtrees there)
FLAKE_FILES_ARGS = ['git', 'ls-files', '*.py', ':!:src/*.py']
Expand Down

0 comments on commit 8b44d01

Please sign in to comment.