Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generator filter): Replace assignment with comparator #22079

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abcdam
Copy link

@abcdam abcdam commented Dec 23, 2024

Fixed typo in filter component produced by vector generate

Summary

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Untested. I stumbled upon it while playing around with vector generate in the cli.
Can be reproduced with e.g. # vector generate /filter. If this PR doesn't follow the guidelines, feel free to delete it and push the fix.

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

Fixed typo in filter component produced by `vector generate`
@abcdam abcdam requested a review from a team as a code owner December 23, 2024 17:13
@bits-bot
Copy link

bits-bot commented Dec 23, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the domain: transforms Anything related to Vector's transform components label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: transforms Anything related to Vector's transform components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants