[AP] Testing Infrastructure #2808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
AlexandreSinger
force-pushed
the
feature-ap-testing
branch
from
4aa2cfb
to
7a4497d
Compare
|
@vaughnbetz This PR is ready for review. It actually a very small PR, the large line change difference comes from adding a lot of fixed block constraints for testing. This fixes some minor bugs in the AP flow regarding carry chains. This also adds some testing infrastructure features such as constraining circuits in a task to specific channel widths and creating fixed architectures for MCNC and VTR. |
vaughnbetz
approved these changes
Nov 18, 2024
vtr_flow/tasks/regression_tests/vtr_reg_strong/strong_ap/mcnc/config/config.txt
Show resolved
Hide resolved
vtr_flow/tasks/regression_tests/vtr_reg_strong/strong_ap/vtr_chain/config/config.txt
Outdated
Show resolved
Hide resolved
Added changes required to test the AP Flow on the MCNC and VTR benchmarks. This creates fixed device sizes for each benchmark which can be used to fairly compare the AP Flow to the default VTR flow. Added the currently passing MCNC and VTR benchmarks to the strong tests to lock in the AP flow. It is a bit unstable right now until the full legalizer is put in. May need to disable a few of the tests.
AlexandreSinger
force-pushed
the
feature-ap-testing
branch
from
7a4497d
to
4650ba1
Compare
|
@vaughnbetz I have updated the comments based on your feedback. Please review and merge when you have a moment! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added changes required to test the AP Flow on the MCNC and VTR benchmarks.
Added the ability the constrain a task benchmark to a specific channel width.
Added fixed device sizes for each benchmark which can be used to fairly compare the AP Flow to the default VTR flow.
Added the currently passing MCNC and VTR benchmarks to the strong tests to lock in the AP flow. It is a bit unstable right now until the full legalizer is put in. May need to disable a few of the tests.