Newline added to JSON return format (For issue 2676)

[mahajanhrishikesh]

What type of PR is this?

• bug
• feature
• enhancement

What problem(s) does this PR solve?

Issue(s) number: 2676

Description:

Code was not adding a newline to the end of the generated JSON from folly

How do you solve it?

Changed line 61 in GetStatsHandler.cpp from
std::string body = returnJson_ ? folly::toPrettyJson(vals) : toStr(vals);
to
std::string body = returnJson_ ? std::strcat(folly::toPrettyJson(vals), "\n") : toStr(vals);

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

• Unit test(positive and negative cases)
• Function test
• Performance test
• N/A

Affects:

• Documentation affected (Please add the label if documentation needs to be modified.)
• Incompatibility (If it breaks the compatibility, please describe it and add the label.）
• If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
• Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

Added an enhancement

[CLAassistant]

All committers have signed the CLA.

[Sophie-Xie]

@mahajanhrishikesh Thanks for contribution! Can you fix the lint? Thanks :)

[mahajanhrishikesh]

@mahajanhrishikesh Thanks for contribution! Can you fix the lint? Thanks :)

Yes! I have to switch it to use snprintf instead of strcat, I will do it soon!

[QingZ11]

@mahajanhrishikesh Thanks for contribution! Can you fix the lint? Thanks :)

Yes! I have to switch it to use snprintf instead of strcat, I will do it soon!

Long time no see! Are you still working on it? And Merry Christmas!