chore: fix build on py36 #5800
Open
chore: fix build on py36 #5800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To build nebula-python in py36, we have to call python setup.py install Note, the wheel built now in Nebula-Python could be installed with pip install <file>.whl
wey-gu
added
ready-for-testing
jievince
previously approved these changes
Jan 9, 2024
yixinglu
previously approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To build nebula-python in py36, we have to call
python setup.py install(only impact those who will to build nebula-python from source in py36)Note, the wheel built now in Nebula-Python could be installed with
pip install <file>.whldependent on vesoft-inc/nebula-python#307
In summary, now:
pdm buildor other tools that support pyproject.tomlpython3 setup.py install(the only draw-back, which impacted our tests makefile.)See more from: vesoft-inc/nebula-python#308
What type of PR is this?