Merge pull request #32617 from vespa-engine/revert-32572-arnej/no-sta…

…ck-trace-on-unsupported-operation Revert "unsupported operation should give a nice error"
vespa-engine · Oct 20, 2024 · 185b001 · 185b001
2 parents 6b0503c + 9fa8a9d
commit 185b001
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/container-search/src/main/java/com/yahoo/search/handler/SearchHandler.java b/container-search/src/main/java/com/yahoo/search/handler/SearchHandler.java
@@ -401,11 +401,6 @@ private Result search(String request, Query query, Chain<Searcher> searchChain)
                                                                + Exceptions.toMessageString(e));
             log.log(Level.FINE, error::getDetailedMessage);
             return new Result(query, error);
-        } catch (UnsupportedOperationException e) {
-            ErrorMessage error = ErrorMessage.createBadRequest("Unsupported operation in [" + request + "]: "
-                                                               + Exceptions.toMessageString(e));
-            log.log(Level.FINE, error::getDetailedMessage);
-            return new Result(query, error);
         } catch (Exception e) {
             log(request, query, e);
             return new Result(query, ErrorMessage.createUnspecifiedError("Failed: " +

diff --git a/container-search/src/main/java/com/yahoo/search/rendering/JsonRenderer.java b/container-search/src/main/java/com/yahoo/search/rendering/JsonRenderer.java
@@ -318,8 +318,7 @@ protected void renderErrors(Set<ErrorMessage> errors) throws IOException {
     }
 
     protected boolean shouldRenderStacktraceOf(Throwable cause) {
-        return  ! (cause instanceof IllegalArgumentException ||
-                   cause instanceof UnsupportedOperationException);
+        return  ! (cause instanceof IllegalArgumentException);
     }
 
     protected void renderCoverage() throws IOException {