Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @FeignClient support #275

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Add @FeignClient support #275

wants to merge 14 commits into from

Conversation

pyltsin
Copy link
Contributor

@pyltsin pyltsin commented Aug 2, 2020

Hello,
Thank you for your plugin! It is very cool.
And thank you for checking and correcting the previous mr. I know - it wasn't good.
I add @FeignClient support and replace navigation-search-box to search-everywhere-box.
May I ask you if this implementation is allowed?
if necessary I am ready to fix it.

https://www.buymeacoffee.com/vartemyev - doesn't work :-(
"Payments are disabled until the creator has selected a payment method. Please contact the creator."

Thanks again!

@codecov
Copy link

codecov bot commented Aug 2, 2020

Codecov Report

Merging #275 (1d2661c) into master (0051ae6) will increase coverage by 0.92%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #275      +/-   ##
============================================
+ Coverage     53.58%   54.51%   +0.92%     
- Complexity      162      177      +15     
============================================
  Files            53       63      +10     
  Lines           502      554      +52     
  Branches        121      130       +9     
============================================
+ Hits            269      302      +33     
- Misses          188      203      +15     
- Partials         45       49       +4     
Impacted Files Coverage Δ Complexity Δ
...rtemev/requestmapper/RequestMappingItemProvider.kt 20.00% <0.00%> (ø) 0.00 <0.00> (ø)
...com/viartemev/requestmapper/RequestMappingModel.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...apper/actions/AbstractRequestMappingContributor.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...questmapper/actions/InboundRequestMappingAction.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...mapper/actions/InboundRequestMappingContributor.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...uestmapper/actions/OutBoundRequestMappingAction.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...apper/actions/OutboundRequestMappingContributor.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...estmapper/contributors/JavaRequestMappingFinder.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...tmapper/contributors/KotlinRequestMappingFinder.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...m/viartemev/requestmapper/extensions/Extensions.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0051ae6...e2d5357. Read the comment docs.

@viartemev
Copy link
Owner

issue #253

<action id="OutBoundRequestMapping" class="com.viartemev.requestmapper.actions.OutBoundRequestMappingAction"
text="Outbound Requests" description="Request mapping">
<add-to-group group-id="GoToTargetEx" anchor="first"/>
<keyboard-shortcut keymap="$default" first-keystroke="shift ctrl o"/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we bind to another keystroke? This one was taken already by IDEA.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, of course. Could you help me? And could you say where you found this keystroke? I can't do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants