-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all remaining logs in dpu, along with some other minor fixes #173
Conversation
Relevant users for this PR:
Auto assigning to relevant reviewers. If you are a relevant reviewer, you can use the Vibinex browser extension to see parts of the PR relevant to you To change comment and auto-assign settings, go to your Vibinex settings page. |
WalkthroughThe recent updates to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 6
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (14)
- vibi-dpu/src/bitbucket/auth.rs (1 hunks)
- vibi-dpu/src/core/approval.rs (1 hunks)
- vibi-dpu/src/core/bitbucket/setup.rs (5 hunks)
- vibi-dpu/src/core/github/comment.rs (1 hunks)
- vibi-dpu/src/core/relevance.rs (4 hunks)
- vibi-dpu/src/core/review.rs (4 hunks)
- vibi-dpu/src/core/trigger.rs (4 hunks)
- vibi-dpu/src/db/hunk.rs (1 hunks)
- vibi-dpu/src/db/prs.rs (3 hunks)
- vibi-dpu/src/github/auth.rs (2 hunks)
- vibi-dpu/src/github/prs.rs (2 hunks)
- vibi-dpu/src/pubsub/listener.rs (1 hunks)
- vibi-dpu/src/utils/coverage.rs (1 hunks)
- vibi-dpu/src/utils/pr_info.rs (1 hunks)
Files skipped from review due to trivial changes (6)
- vibi-dpu/src/bitbucket/auth.rs
- vibi-dpu/src/core/approval.rs
- vibi-dpu/src/core/bitbucket/setup.rs
- vibi-dpu/src/core/github/comment.rs
- vibi-dpu/src/core/review.rs
- vibi-dpu/src/utils/coverage.rs
Additional comments not posted (19)
vibi-dpu/src/utils/pr_info.rs (1)
3-3
: Adding theClone
trait toPrInfo
is a good enhancement for usability.vibi-dpu/src/db/hunk.rs (2)
34-34
: Changing the log level todebug
for detailed logging is appropriate.
37-37
: Changing the log level todebug
for detailed logging is appropriate.vibi-dpu/src/core/trigger.rs (4)
22-22
: The log message provides useful information about the PR being processed.
42-42
: The parameter change to usepr_info_opt
instead ofaccess_token
improves clarity and functionality.
99-99
: The parameter change to usepr_info_opt
instead ofaccess_token
improves clarity and functionality.
104-104
: The parameter change to usepr_info_opt
instead ofaccess_token
improves clarity and functionality.vibi-dpu/src/github/prs.rs (3)
128-129
: Using a method call onProviderEnum
instead of a hardcoded string improves code maintainability and readability.
Line range hint
139-139
: The log message provides useful information about the PR event being processed.
Line range hint
149-149
: The log message provides useful information about unrecognized PR events.vibi-dpu/src/db/prs.rs (3)
127-128
: Using a method call onProviderEnum
instead of a hardcoded string improves code maintainability and readability.
139-139
: The log message provides useful information about the PR event being processed.
149-149
: The log message provides useful information about unrecognized PR events.vibi-dpu/src/pubsub/listener.rs (2)
54-54
: The log message provides useful information about the processing of triggers.
56-56
: The log message provides useful information about the processing of triggers.vibi-dpu/src/core/relevance.rs (4)
10-11
: The log level change frominfo
todebug
for the message "Process relevance for PR" is appropriate for reducing log verbosity.
55-55
: The log level change frominfo
todebug
for the message "No review record found in db, inserting comment" is appropriate for reducing log verbosity.
61-61
: The log level change frominfo
todebug
for the message "No relevance found in db, inserting comment" is appropriate for reducing log verbosity.
200-200
: The log level change frominfo
todebug
for the message "provider_id" is appropriate for reducing log verbosity.
Relevant users for this PR:
Total Coverage for PR: 23.08% If you are a relevant reviewer, you can use the Vibinex browser extension to see parts of the PR relevant to you To change comment and auto-assign settings, go to your Vibinex repository settings page. |
Please check the action items covered in the PR -